Add baggage test to AbstractHttpServerTest #13027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

trask merged 5 commits into open-telemetry:main from xiepuhuan:add-baggage-test-for-abstract-http-server-test

Jan 14, 2025

Contributor

xiepuhuan commented Jan 11, 2025

Related to #13016

xiepuhuan added 2 commits

January 11, 2025 19:52


          Add baggage test to AbstractHttpServerTest

efa4dcd


          Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

a8daa71

…nstrumentation into add-baggage-test-for-abstract-http-server-test

xiepuhuan requested a review from a team as a code owner

January 11, 2025 11:57


          Add baggage-processor configuration for javaagent testing

7a9b214

trask approved these changes

View reviewed changes

Member

trask left a comment

nice!

trask added this to the v2.12.0 milestone

laurit reviewed

View reviewed changes

...src/main/java/io/opentelemetry/instrumentation/testing/junit/http/HttpServerTestOptions.java Show resolved Hide resolved

laurit reviewed

View reviewed changes

...rc/main/java/io/opentelemetry/instrumentation/testing/junit/http/AbstractHttpServerTest.java Show resolved Hide resolved

laurit reviewed

View reviewed changes

...rc/main/java/io/opentelemetry/instrumentation/testing/junit/http/AbstractHttpServerTest.java Outdated Show resolved Hide resolved

laurit reviewed

View reviewed changes

...rc/main/java/io/opentelemetry/instrumentation/testing/junit/http/AbstractHttpServerTest.java Show resolved Hide resolved

laurit reviewed

View reviewed changes

conventions/src/main/kotlin/io.opentelemetry.instrumentation.javaagent-testing.gradle.kts Outdated Show resolved Hide resolved


          1. Add comment for baggage test

299154c

2. Assert response status
3. Specify the key used by baggage

linux-foundation-easycla bot commented Jan 13, 2025 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: xiepuhuan / name: xiepuhuan (efa4dcd, 7a9b214, 299154c, a8daa71, 0ca185f)

github-actions bot added the test native label

laurit reviewed

View reviewed changes

.../java/io/opentelemetry/instrumentation/spring/webmvc/v5_3/JavaxHttpServletRequestGetter.java Outdated Show resolved Hide resolved

laurit reviewed

View reviewed changes

.../java/io/opentelemetry/instrumentation/spring/webmvc/v5_3/JavaxHttpServletRequestGetter.java Outdated Show resolved Hide resolved


          Implement ExtendedTextMapGetter in spring-webmvc-5.3 instrumentation

0ca185f

xiepuhuan force-pushed the add-baggage-test-for-abstract-http-server-test branch from 6d11c9a to 0ca185f Compare

January 13, 2025 13:58

laurit approved these changes

View reviewed changes

trask merged commit f877ec9 into open-telemetry:main

58 checks passed

xiepuhuan mentioned this pull request

Implement ExtendedTextMapGetter in instrumentations #12868

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels